[fix](aggregate) Fix nullable aggregate visitor dispatch#64885
Open
morrySnow wants to merge 1 commit into
Open
[fix](aggregate) Fix nullable aggregate visitor dispatch#64885morrySnow wants to merge 1 commit into
morrySnow wants to merge 1 commit into
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Bool aggregate functions such as bool_and, bool_or, and bool_xor extend NullableAggregateFunction, but their AggregateFunctionVisitor default methods delegated directly to visitAggregateFunction. This bypassed visitor implementations that specialize NullableAggregateFunction. Route these bool aggregate visitor methods through visitNullableAggregateFunction and add a unit test that verifies all current NullableAggregateFunction defaults dispatch to the nullable visitor path.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- ./run-fe-ut.sh --run org.apache.doris.nereids.trees.expressions.visitor.AggregateFunctionVisitorTest
- cd fe && mvn checkstyle:check -pl fe-core
- Behavior changed: Yes. Nullable bool aggregate functions now use the NullableAggregateFunction visitor default path.
- Does this need documentation: No
morrySnow
requested review from
924060929,
englefly and
starocean999
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
Contributor
Author
|
run buildall |
morrySnow
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Reviewed the two-file PR for nullable aggregate visitor dispatch. I did not find a blocking issue or a valuable inline comment to add.
Critical checkpoint conclusions:
- Goal/test: The change fixes
BoolAnd,BoolOr, andBoolXorso their visitor defaults dispatch throughvisitNullableAggregateFunction; this matches theirNullableAggregateFunctionhierarchy and theAdjustAggregateNullableForEmptySetpath that rewrites empty-group aggregate nullability. The added JUnit reflection test covers the current concrete nullable aggregate visitor methods, includingForEachCombinator. - Scope: The production change is small and focused: three default visitor dispatch calls plus one targeted test.
- Parallel paths: I checked the remaining aggregate visitor defaults against the aggregate class hierarchy; the methods still dispatching to
visitAggregateFunctioncorrespond to non-nullable/base aggregate paths, while the current nullable aggregate subclasses are covered by nullable dispatch. A static comparison found no current nullable subclass missing from the new test list. - Concurrency/lifecycle/config/compatibility/transactions/storage/observability: Not applicable to this FE visitor-dispatch change; no new config, protocol, persisted state, locking, or runtime lifecycle behavior is introduced.
- Test/style validation:
git diff --check FETCH_HEAD..HEADpassed. I did not run FE unit tests because this checkout lacksthirdparty/installedandthirdparty/installed/bin/protoc, and FE AGENTS instructions require stopping before FE build/test when protoc is absent.
User focus: No additional user-provided focus was present.
Subagent conclusions: optimizer-rewrite and tests-session-config both reported no candidates in their initial passes. After the main ledger was updated with a no-inline-comment proposed final set, convergence round 1 ended with both subagents replying NO_NEW_VALUABLE_FINDINGS for the same current ledger/comment set.
Contributor
TPC-H: Total hot run time: 29198 ms |
Contributor
TPC-DS: Total hot run time: 172000 ms |
Contributor
ClickBench: Total hot run time: 25.22 s |
924060929
approved these changes
Jun 26, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
related to #55643
Problem Summary: Bool aggregate functions such as bool_and, bool_or, and bool_xor extend NullableAggregateFunction, but their AggregateFunctionVisitor default methods delegated directly to visitAggregateFunction. This bypassed visitor implementations that specialize NullableAggregateFunction. Route these bool aggregate visitor methods through visitNullableAggregateFunction and add a unit test that verifies all current NullableAggregateFunction defaults dispatch to the nullable visitor path.
Release note
None
Check List (For Author)